Reduce margin for START_OF_MODERN_ERA in delta lake stats #15005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
approved these changes
Nov 14, 2022
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeAnalyze.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeAnalyze.java
Outdated
Show resolved
Hide resolved
raunaqmorarka
force-pushed
the
fix-modern-era
branch
from
e569d36 to
a9df0d8
Compare
|
Should there be a change in |
d_date column in TPCDS table date_dim has minimum value of `1900-01-02` This change allows delta lake to provide the correct lower bound instead of NULL in columns statistics to the CBO. This fixes the query plan for TPCDS q72.
raunaqmorarka
force-pushed
the
fix-modern-era
branch
from
a9df0d8 to
54623aa
Compare
We don't have Tpc plan checks for delta lake currently, it does look like a good idea to add it at some point. |
Closed
yes, i know
what about having an issue so we can plan this work? |
Created #15045 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
d_date column in TPCDS table date_dim has minimum value of
1900-01-02This change allows delta lake to provide the correct lower bound instead of NULL in columns statistics to the CBO.
This fixes the query plan for TPCDS q72.
Non-technical explanation
Improve statistics for DATE columns in delta lake
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: